Closed
Conversation
dgdavid
changed the title
Contributor
Author
|
#1334 fixes the problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We've found an extra, not needed, even blocking redirection to the product selector once the product is configured.
We think this happens because the condition, which wrongly leaves in the OverviewPage component for historical reasons (it was the main component in the previous UI / routes schema), is triggered before the component has the chance to run its useEffects.
Solution
Place the condition in App.jsx, but inside the internal
Contentcomponent AFTER the products list has been loaded as a way to ensure that useEffects has been already triggered. A hotfix, indeed.Testing
To be tested with a live ISO
Follow up
Refactor the App.jsx component to drop its "router" behaviour and rely more, when possible, in React Router and route loaders or whatever other mechanism that feels better than current one.