Skip to content

fix(dbus): fix users issues detection #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imobachgs merged 3 commits into from
Jun 12, 2024
Merged

fix(dbus): fix users issues detection #1317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c41c96
fix(dbus): fix users issues detection
imobachgs Jun 12, 2024
1ab1d78
chore: make Rubocop happy
imobachgs Jun 12, 2024
b1961af
doc(dbus): remove ServiceStatus for Users1 object
imobachgs Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion doc/dbus/bus/org.opensuse.Agama1.ServiceStatus.bus.xml
View file
Open in desktop

This file was deleted.

35 changes: 0 additions & 35 deletions doc/dbus/org.opensuse.Agama1.ServiceStatus.doc.xml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion service/lib/agama/dbus/manager_service.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ def manager_dbus
end

def users_dbus
@users_dbus ||= Agama::DBus::Users.new(users, logger)
@users_dbus ||= Agama::DBus::Users.new(manager.users, logger)
end
end
end
Expand Down
2 changes: 1 addition & 1 deletion service/lib/agama/users.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ def update_issues
unless root_password? || root_ssh_key? || first_user?
new_issues << Issue.new(
_("Defining a user, setting the root password or a SSH public key is required"),
source: Issue::Source::CONFIG,
source: Issue::Source::CONFIG,
severity: Issue::Severity::ERROR
)
end
Expand Down