Skip to content

Comments

Fix issues with webpack and fonts#131

Merged
dgdavid merged 3 commits intomasterfrom
fix-fonts-issues
Apr 12, 2022
Merged

Fix issues with webpack and fonts#131
dgdavid merged 3 commits intomasterfrom
fix-fonts-issues

Conversation

@dgdavid
Copy link
Contributor

@dgdavid dgdavid commented Apr 11, 2022

Problem

Recommended fonts by EOS were not working after migrating to webpack.

Solution

Stop using the @fontsource dependencies and fine-tuning the webpack config file to copy fonts from src/assets to dist, but only those that are in use in the src/assets/fonts.scss file.

Acknowledgment

Thanks to @backpackerhh for helping me to spot that url: false in the webpack config file that was driving me crazy 😉 It avoids parsing any paths specified in url(...). See https://github.com/webpack-contrib/css-loader#url

Testing

  • Tested manually

@dgdavid dgdavid requested a review from imobachgs April 11, 2022 16:15
@coveralls
Copy link

coveralls commented Apr 11, 2022

Pull Request Test Coverage Report for Build 2149782792

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.357%

Totals Coverage Status
Change from base Build 2148611471: 0.0%
Covered Lines: 973
Relevant Lines: 1187

💛 - Coveralls

@dgdavid dgdavid merged commit 6bb8068 into master Apr 12, 2022
@dgdavid dgdavid deleted the fix-fonts-issues branch April 12, 2022 07:26
@dgdavid dgdavid mentioned this pull request Apr 12, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants