Closed
Conversation
Pull Request Test Coverage Report for Build 2095794380
💛 - Coveralls |
Contributor
|
I like the idea. It would help to keep the screenshots up-to-date. I think it is worth giving it a try. |
Contributor
|
I also like it. |
Contributor
Author
|
I'm still thinking that would be a good thing for the project, but now that we switched to webpack we should look for a similar solution in the webpack world. Thus, closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A mix between a PoC and RFC for automated screenshots using viteshot
A bit tricky at this moment because there are some warnings and the development server must be running (?) for taking the screenshots with
npm run screenshotsBut the idea is to have a way to automating and sending screenshots of specific components, easing the process to make a PR and keep up-to-date the screenshots shown in the README, always using the same sizes and so on (see reviewing screenshots and screenshot consistency).
Useful links: