Skip to content

[WIP] [RFC] [PoC] Automated screenshots#117

Closed
dgdavid wants to merge 4 commits intomasterfrom
screenshots
Closed

[WIP] [RFC] [PoC] Automated screenshots#117
dgdavid wants to merge 4 commits intomasterfrom
screenshots

Conversation

@dgdavid
Copy link
Contributor

@dgdavid dgdavid commented Apr 5, 2022

A mix between a PoC and RFC for automated screenshots using viteshot

A bit tricky at this moment because there are some warnings and the development server must be running (?) for taking the screenshots with npm run screenshots

But the idea is to have a way to automating and sending screenshots of specific components, easing the process to make a PR and keep up-to-date the screenshots shown in the README, always using the same sizes and so on (see reviewing screenshots and screenshot consistency).

Useful links:

@coveralls
Copy link

coveralls commented Apr 5, 2022

Pull Request Test Coverage Report for Build 2095794380

  • 0 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 81.705%

Changes Missing Coverage Covered Lines Changed/Added Lines %
web/src/InstallationFinished.screenshot.jsx 0 1 0.0%
web/src/ScreenshotsWrapper.jsx 0 3 0.0%
Totals Coverage Status
Change from base Build 2095008124: -0.2%
Covered Lines: 1026
Relevant Lines: 1247

💛 - Coveralls

@imobachgs
Copy link
Contributor

imobachgs commented Apr 5, 2022

I like the idea. It would help to keep the screenshots up-to-date. I think it is worth giving it a try.

@teclator
Copy link
Contributor

teclator commented Apr 6, 2022

I also like it.

@dgdavid
Copy link
Contributor Author

dgdavid commented Apr 12, 2022

I'm still thinking that would be a good thing for the project, but now that we switched to webpack we should look for a similar solution in the webpack world.

Thus, closing this PR.

@dgdavid dgdavid closed this Apr 12, 2022
@dgdavid dgdavid deleted the screenshots branch April 12, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments