Merged
Conversation
imobachgs
approved these changes
Dec 23, 2021
Contributor
Author
|
lets mergge this one and try to rebase #4 |
dgdavid
added a commit
that referenced
this pull request
Jul 11, 2024
## Problem [Switching from the former UI to the current approach](#1202) left behind a lot of things to review, dead components and a CSS clean up among them. ## Solution Drop dead components and make as much clean-up rounds as needed. This can be considered `Round #1`, made in the middle of more urgent work. ## Testing Tested manually ## Screenshots Visual changes after this PR should keep at minimum. In any case, it's preferred that reviewers give the UI a shot taking the time they need.
teclator
added a commit
that referenced
this pull request
Jul 24, 2025
## Problem The CLI needs to encode the connection Id in order to use it in the URL for adding or updating it. - https://bugzilla.suse.com/show_bug.cgi?id=1246930 - https://trello.com/c/H8mxZJxy/5185-2-agama-loading-a-profile-tries-to-create-an-existing-network- ## Solution Encode the connection id in order to use it in the URL path for adding or updating a connection ## Testing - *Tested manually* **Example profile net.json** ``` suse@vikingo:~$ cat net.json { "product": { "id": "Tumbleweed" }, "network": { "connections": [ { "id": "Wired #1", "status": "up" } ] } } suse@vikingo:~$ agama config load < net.json ✓ The profile is valid. suse@vikingo:~$ agama config load < net.json ✓ The profile is valid. ## REMOVED IRRELEVANT DATA suse@vikingo:~$ agama config show { "network": { "connections": [ { "id": "Wired #1", "method4": "auto", "method6": "auto", "ignoreAutoDns": false, "status": "up", "autoconnect": true, "persistent": true } ] } } ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.