Skip to content

Conversation

@mvidner
Copy link
Contributor

@mvidner mvidner commented Jun 4, 2025

See agama-project/agama#2347

  • update and switch from Draft when the main PR is merged

mvidner added a commit to agama-project/agama that referenced this pull request Jun 11, 2025
## Problem

The split between `agama config` and `agama profile` commands is
arbitrary, and the subcommands are not very consistent.

- https://trello.com/c/BtqeDyzZ


## Solution

Following a discussion:
- `agama profile import` is replaced by `agama config generate | agama
config load`
- `agama profile evaluate` and `agama profile autoyast` are replaced by
`agama config generate`
- `agama profile validate` renamed to `agama config validate`

More consistency in stdio handling, adding `--output` option

- [x] update `agama-auto`

Review suggestion:
- `service/test/integration/profile_itest.rb` is an integration test,
supposed to be human readable. Please suggest improvements both in
domain coverage and test readabililty. See
`service/test/integration/README.md` on how to run it

## Testing

- `service/test/integration/profile_itest.rb` extended
- manual test of `inst.auto=http://.../config.jsonnet` and `inst.auto=`
finding it on `OEMDRV` (see [a
gist](https://gist.github.com/mvidner/d377768d54ae0ba39cd1e62672eec99a)
for setup)


## Screenshots

*If the fix affects the UI attach some screenshots here.*

## Documentation

- [x] update [cli.md][] with `cargo xtask markdown`:
agama-project/agama-project.github.io#84
- [x] ~*.schema.json~
- [x] related:
agama-project/agama-project.github.io#81 (by
Imo)
- Run: `git ls-files '*.md'`

[cli.md]:
https://github.com/agama-project/agama-project.github.io/blob/main/docs/user/cli.md
@mvidner mvidner marked this pull request as ready for review June 11, 2025 06:01
@mvidner mvidner merged commit a85b9df into main Jun 11, 2025
5 checks passed
@mvidner mvidner deleted the agama-config-generate branch June 11, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants