Merged
Conversation
3 tasks
jreidinger
added a commit
to agama-project/agama
that referenced
this pull request
Feb 19, 2025
## Problem The linuxrc provides quite useful option to specify remote "info" file that contain additional parameters. It helps when kernel command line is restricted by amount of characters or if writing to it is annoying and it is better to point to that info file. ## Solution Implement support for `agama.info`. Also implement filtering of agama specific kernel options and write it to `/etc/agama/kernel.cmdline.conf` so yast2-bootloader can use it for proposal. Note: agama.info does not support all linuxrc info features like it quire correct name `agama.info=` without any additional dots, dashes or different letter case. It also currently support only single info parameter and it cannot be recursive, so additional info parameters are not expanded. And last but not least it supports only url that is supported by curl. ## Testing - tested manually with own iso and passing `live.password=` param. ## TODO: - [x] merged after Beta1 - [x] add changelog before merge to avoid too much conflicts - [x] document new option in agama github page - agama-project/agama-project.github.io#42
imobachgs
reviewed
Feb 19, 2025
docs/user/boot_options/index.md
Outdated
| ``` | ||
|
|
||
| :::warning | ||
| Available from Agama12. |
Contributor
There was a problem hiding this comment.
I would omit this, because we are not putting this information for other options.
Contributor
Author
There was a problem hiding this comment.
yeap, but on other hand as first beta for SLES is out, we should somehow start indicating when it is available.
docs/user/boot_options/index.md
Outdated
| ::: | ||
|
|
||
| :::warning | ||
| Supports only parameters specified on this section. Kernel parameters are ignored. |
Contributor
There was a problem hiding this comment.
I do not think it is a warning. You can make it part of the description of the options or, if you want to emphasize this, let's use a simple note.
Co-authored-by: Imobach González Sosa <igonzalezsosa@suse.com>
imobachgs
approved these changes
Mar 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related code change: agama-project/agama#1896
preview https://agama-preview-pull-42.surge.sh/docs/user/boot_options