Fix trailing semicolon in expression from make_static_outline macro#186
Merged
Conversation
Owner
Author
It was only recently made to lint on non-local macros: rust-lang/rust#159222.
It was deny-by-default since long ago just easy to miss in certain cases due to the above. I'm assuming this was an unintentional omission because it seems highly undesirable to only surface an FCW when it has already been made deny-by-default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This FCW was
recentlya long time ago moved to deny-by-default and breaks subrandr on Rust nightly.I use exclusively nightly Rust when building locally but for some reason this did not show up as a warning before. Since this means a future Rust release will likely break existing subrandr releases, we will need a point release when that happens.