style: more declarative

afifurrohman-id · Dec 10, 2023 · 7a0a5e9 · 7a0a5e9
1 parent cddd182
commit 7a0a5e9
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 50 deletions.
diff --git a/.github/workflows/live.yaml b/.github/workflows/live.yaml
@@ -21,24 +21,26 @@ jobs:
           PORT: ${{secrets.PORT}}
 
         steps:
-            - name: Clone Repository
-              uses: actions/checkout@v4
+            - uses: actions/checkout@v4
+            - uses: docker/setup-qemu-action@v3
+            - uses: docker/setup-buildx-action@v3
 
             - uses: jbergstroem/hadolint-gh-action@v1
               with:
                 dockerfile: build/package/**Dockerfile
 
+            - name: Build Image Test
+              uses: docker/build-push-action@v5
+              with:
+                context: .
+                load: true
+                file: build/package/test.Dockerfile
+                tags: ${{github.event.repository.name}}
+
             - name: Unit testing # Using staging environment
               run: |
-                  docker build -t ${{github.event.repository.name}} -f build/package/test.Dockerfile .
-
                   docker run --rm --name ${{github.event.repository.owner.login}} --add-host=host.docker.internal:host-gateway -e GOOGLE_CLOUD_STORAGE_SERVICE_ACCOUNT -e GOOGLE_CLOUD_STORAGE_BUCKET -e SERVER_URI -e GOOGLE_OAUTH2_REFRESH_TOKEN_TEST -e APP_ENV -e PORT -e GOOGLE_OAUTH2_CLIENT_ID_TEST -e GOOGLE_OAUTH2_CLIENT_SECRET_TEST ${{github.event.repository.name}} go test -v --cover -ldflags '-w -s' ./...
 
-            - name: Clean up
-              if: always()
-              run: |
-                  docker rmi ${{github.event.repository.name}}
-
     deploy:
         needs: [ test ]
         runs-on: ubuntu-latest
@@ -51,24 +53,17 @@ jobs:
         permissions:
           packages: write
         steps:
-          - name: Clone Repository
-            uses: actions/checkout@v4
-
-          - name: Setup QEMU
-            uses: docker/setup-qemu-action@v3
-
-          - name: Set up Docker Buildx
-            uses: docker/setup-buildx-action@v3
+          - uses: actions/checkout@v4
+          - uses: docker/setup-qemu-action@v3
+          - uses: docker/setup-buildx-action@v3
 
-          - name: Login to container registry
-            uses: docker/login-action@v3
+          - uses: docker/login-action@v3
             with:
               registry: ${{env.REGISTRY}}
               username: ${{github.repository_owner}}
               password: ${{secrets.GITHUB_TOKEN}}
 
-          - name: Build Image &  Push to Registry
-            uses: docker/build-push-action@v5
+          - uses: docker/build-push-action@v5
             with:
               context: .
               file: build/package/Dockerfile
@@ -77,13 +72,11 @@ jobs:
                 ${{env.IMAGE_NAME}}:${{github.sha}}
                 ${{env.IMAGE_NAME}}
 
-          - name: Azure Login
-            uses: azure/login@v1
+          - uses: azure/login@v1
             with:
               creds: ${{ secrets.AZURE_CREDENTIALS }}
 
-          - name: Deploy to Azure Container Apps
-            uses: azure/container-apps-deploy-action@v2
+          - uses: azure/container-apps-deploy-action@v2
             with:
               registryUrl: ${{env.REGISTRY}}
               containerAppName: ${{github.event.repository.name}}

diff --git a/.github/workflows/preview.yaml b/.github/workflows/preview.yaml
@@ -21,27 +21,33 @@ jobs:
           PORT: ${{secrets.PORT}}
 
         steps:
-            - name: Clone Repository
-              uses: actions/checkout@v4
+            - uses: actions/checkout@v4
+            - uses: docker/setup-qemu-action@v3
+            - uses: docker/setup-buildx-action@v3
 
             - uses: jbergstroem/hadolint-gh-action@v1
               with:
                 dockerfile: build/package/**Dockerfile
 
-            - name: Run Docker Compose
+            - name: Run Firebase Emulator
               run: docker compose -f deployments/compose.yaml up -d
 
+            - name: Build Image Test
+              uses: docker/build-push-action@v5
+              with:
+                context: .
+                load: true
+                file: build/package/test.Dockerfile
+                tags: ${{github.event.repository.name}}
+
             - name: Unit testing
               run: |
-                docker build -t ${{github.event.repository.name}} -f build/package/test.Dockerfile .
-
                 docker run --rm --name ${{github.event.repository.owner.login}} --add-host=host.docker.internal:host-gateway -e GOOGLE_CLOUD_STORAGE_SERVICE_ACCOUNT -e GOOGLE_CLOUD_STORAGE_BUCKET -e SERVER_URI -e GOOGLE_CLOUD_STORAGE_EMULATOR_ENDPOINT -e GOOGLE_OAUTH2_REFRESH_TOKEN_TEST -e PORT -e GOOGLE_OAUTH2_CLIENT_ID_TEST -e GOOGLE_OAUTH2_CLIENT_SECRET_TEST ${{github.event.repository.name}} go test -v --cover -ldflags '-w -s' ./...
 
-            - name: Clean up
+            - name: Clean up Services
               if: always()
-              run: |
-                  docker rmi ${{github.event.repository.name}}
-                  docker compose -f deployments/compose.yaml down -v --rmi all
+              continue-on-error: true
+              run: docker compose -f deployments/compose.yaml down -v --rmi all
 
     deploy:
         needs: [ test ]
@@ -55,24 +61,17 @@ jobs:
             REGISTRY: ghcr.io
             IMAGE_NAME: ghcr.io/${{github.repository_owner}}/${{github.event.repository.name}}
         steps:
-            - name: Clone Repository
-              uses: actions/checkout@v4
-
-            - name: Setup QEMU
-              uses: docker/setup-qemu-action@v3
+            - uses: actions/checkout@v4
+            - uses: docker/setup-qemu-action@v3
+            - uses: docker/setup-buildx-action@v3
 
-            - name: Set up Docker Buildx
-              uses: docker/setup-buildx-action@v3
-
-            - name: Login to container registry
-              uses: docker/login-action@v3
+            - uses: docker/login-action@v3
               with:
                 registry: ${{env.REGISTRY}}
                 username: ${{github.repository_owner}}
                 password: ${{secrets.GITHUB_TOKEN}}
 
-            - name: Build Image &  Push to Registry
-              uses: docker/build-push-action@v5
+            - uses: docker/build-push-action@v5
               with:
                 context: .
                 file: build/package/Dockerfile
@@ -81,13 +80,11 @@ jobs:
                   ${{env.IMAGE_NAME}}:${{github.sha}}
                   ${{env.IMAGE_NAME}}
 
-            - name: Azure Login
-              uses: azure/login@v1
+            - uses: azure/login@v1
               with:
                 creds: ${{ secrets.AZURE_CREDENTIALS }}
 
-            - name: Deploy to Azure Container Apps
-              uses: azure/container-apps-deploy-action@v2
+            - uses: azure/container-apps-deploy-action@v2
               with:
                 registryUrl: ${{env.REGISTRY}}
                 containerAppName: ${{github.event.repository.name}}-staging