Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(FTL-17137): add affinidi-did-resolver-cache-sdk unit tests #31

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

YoussefAWasfy
Copy link
Collaborator

No description provided.

@YoussefAWasfy YoussefAWasfy marked this pull request as draft September 24, 2024 16:34
@YoussefAWasfy YoussefAWasfy marked this pull request as ready for review September 25, 2024 10:15
@YoussefAWasfy YoussefAWasfy changed the title test(FTL-17137): add request queue unit tests test(FTL-17137): add affinidi-did-resolver-cache-sdk unit tests Sep 25, 2024
Copy link
Collaborator

@anton-iskryzhytskyi anton-iskryzhytskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a check for errors, as some functions can panic for non-expected reason?

Copy link
Collaborator

@anton-iskryzhytskyi anton-iskryzhytskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@robert-affinidi robert-affinidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoussefAWasfy YoussefAWasfy merged commit c22af1f into main Sep 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants