-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why does pyaff4 needs aff4-snappy instead of python-snappy? #9
Comments
python snappy is not a hermetic distribution - it requires libsnappy to be installed on the system. It then builds the python binding with a runtime requirement for libsnappy. This is not an acceptable solution. The main change is this commit aff4/aff4-snappy@45397f7 Modified to build snappy inline so we do not need to link against libsnappy. For something as trivial as snappy it does not make sense to include a shared object - just build it statically into the binding. |
thx for the context Let me know if you're OK with the following changes:
|
Thanks for the ping I totally missed it :-).
Python-snappy builds a shared object which depends on the system
libsnappy.so or libsnappy.dll. this makes it not hermetic so we can not use
it to distribute on pipy.
The aff4-snappy fork builds the bindings and the snappy code into a self
contained module.
This might have changed recently I have not looked at the package for a
long time. But you can verify it using ldd on the produced .so file, or try
to build on Windows which will fail unless you have snappy installed.
Thanks
Mike
…On Mon, Feb 24, 2020, 19:15 Joachim Metz ***@***.***> wrote:
@scudette <https://github.com/scudette> @blschatz
<https://github.com/blschatz> friendly ping any feedback/input?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9?email_source=notifications&email_token=AA5NRIXCXR3KY3HZYDTJTCLREN62VA5CNFSM4HHVERZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMW5VLY#issuecomment-590207663>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5NRIUWDZBSPJ2I64BJQD3REN62VANCNFSM4HHVERZQ>
.
|
My point was more to change pyaff4 to include snappy as is done for pytsk (as a git submodule) and create an hermetic build? |
Ah sorry I don't read the entire thread (just send an email). Sure what you suggest sounds great. Will accept any pr to do this :-) |
Happy to help but could you maybe follow up on the steps proposed in #9 (comment) |
pyaff4 depends on aff4-snappy
Which is forked from python-snappy:
@blschatz @scudette I'm looking into building pyaff4 for testing purposes, some questions:
The text was updated successfully, but these errors were encountered: