Merge tag 'v0.28.1' into multi-node

0.28.1 Release

* tag 'v0.28.1': (36 commits)
  Cut 0.28.1 release.
  Bump the iso version to 0.28.1.
  Remove untainting logic.
  Fix vboxsf host mounting.
  Update cri-tools to 1.11.1.
  Reuse the FeatureGates field to parse kubeadm and component feature gates
  Update kubeadm config template
  Fix generate config failed
  Add feature gates support for Kubeadm
  Keep both sets of instructions
  Prefer choco over manual installation for windows
  Add heketi and gluster dependencies to minikube.iso
  Add documentation.
  Add nvidia-driver-installer and nvidia-gpu-device-plugin addons.
  Add GPU support to minikube.
  enquotes PATH to guard against spaces
  Fixes kubernetes#2274
  Make builds work with no GOPATH env var explicitly set - this is not needed since 1.8 but the build required it to be set
  Add missing controlPlaneEndpoint to fix kubeadm templates test
  Code review feedback.
  ...

CHANGELOG.md

@@ -1,5 +1,14 @@
 # Minikube Release Notes
 
+# Version 0.28.1 - 7/16/2018
+* vboxsf Host Mounting fixed (Linux Kernel version downgraded to 4.15 from 4.16) [#2986](https://github.com/kubernetes/minikube/pull/2986)
+* cri-tools udpated to 1.11.1 [#2986](https://github.com/kubernetes/minikube/pull/2986)
+* Feature Gates support added to kubeadm bootstrapper [#2951](https://github.com/kubernetes/minikube/pull/2951)
+* Kubernetes 1.11 build support added [#2943](https://github.com/kubernetes/minikube/pull/2943)
+* GPU support for kvm2 driver added [#2936](https://github.com/kubernetes/minikube/pull/2936)
+* nginx ingress controller updated to 0.16.2 [#2930](https://github.com/kubernetes/minikube/pull/2930)
+* heketi and gluster dependencies added to minikube ISO [#2925](https://github.com/kubernetes/minikube/pull/2925)
+
 # Version 0.28.0 - 6/12/2018
 * Minikube status command fixes [#2894](https://github.com/kubernetes/minikube/pull/2894)
 * Boot changes to support virsh console [#2887](https://github.com/kubernetes/minikube/pull/2887)

Makefile

@@ -15,7 +15,7 @@
 # Bump these on release
 VERSION_MAJOR ?= 0
 VERSION_MINOR ?= 28
-VERSION_BUILD ?= 0
+VERSION_BUILD ?= 1
 VERSION ?= v$(VERSION_MAJOR).$(VERSION_MINOR).$(VERSION_BUILD)
 DEB_VERSION ?= $(VERSION_MAJOR).$(VERSION_MINOR)-$(VERSION_BUILD)
 INSTALL_SIZE ?= $(shell du out/minikube-windows-amd64.exe | cut -f1)
@@ -26,13 +26,18 @@ HYPERKIT_BUILD_IMAGE 	?= karalabe/xgo-1.8.3
 BUILD_IMAGE 	?= k8s.gcr.io/kube-cross:v1.9.1-1
 ISO_BUILD_IMAGE ?= $(REGISTRY)/buildroot-image
 
-ISO_VERSION ?= v0.28.0
+ISO_VERSION ?= v0.28.1
 ISO_BUCKET ?= minikube/iso
 
+MINIKUBE_VERSION ?= $(ISO_VERSION)
+MINIKUBE_BUCKET ?= minikube/releases
+MINIKUBE_UPLOAD_LOCATION := gs://${MINIKUBE_BUCKET}
+
 KERNEL_VERSION ?= 4.16.14
 
 GOOS ?= $(shell go env GOOS)
 GOARCH ?= $(shell go env GOARCH)
+GOPATH ?= $(shell go env GOPATH)
 BUILD_DIR ?= ./out
 $(shell mkdir -p $(BUILD_DIR))
 
@@ -164,6 +169,11 @@ else
 		$(ISO_BUILD_IMAGE) /usr/bin/make out/minikube.iso
 endif
 
+iso_in_docker:
+	docker run -it --rm --workdir /mnt --volume $(CURDIR):/mnt $(ISO_DOCKER_EXTRA_ARGS) \
+		--user $(shell id -u):$(shell id -g) --env HOME=/tmp --env IN_DOCKER=1 \
+		$(ISO_BUILD_IMAGE) /bin/bash
+
 test-iso:
 	go test -v $(REPOPATH)/test/integration --tags=iso --minikube-args="--iso-url=file://$(shell pwd)/out/buildroot/output/images/rootfs.iso9660"
 
@@ -182,9 +192,9 @@ drivers: out/docker-machine-driver-hyperkit out/docker-machine-driver-kvm2
 
 .PHONY: images
 images: localkube-image localkube-dind-image localkube-dind-image-devshell
-	gcloud docker -- push gcr.io/k8s-minikube/localkube-image:$(TAG)
-	gcloud docker -- push gcr.io/k8s-minikube/localkube-dind-image:$(TAG)
-	gcloud docker -- push gcr.io/k8s-minikube/localkube-dind-image-devshell:$(TAG)
+	gcloud docker -- push $(REGISTRY)/localkube-image:$(TAG)
+	gcloud docker -- push $(REGISTRY)/localkube-dind-image:$(TAG)
+	gcloud docker -- push $(REGISTRY)/localkube-dind-image-devshell:$(TAG)
 
 .PHONY: integration
 integration: out/minikube
@@ -204,11 +214,11 @@ out/test.d: pkg/minikube/assets/assets.go
 
 -include out/test.d
 test:
-	./test.sh
+	GOPATH=$(GOPATH) ./test.sh
 
 pkg/minikube/assets/assets.go: $(shell find deploy/addons -type f)
 	which go-bindata || GOBIN=$(GOPATH)/bin go get github.com/jteeuwen/go-bindata/...
-	PATH=$(PATH):$(GOPATH)/bin go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
+	PATH="$(PATH):$(GOPATH)/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
 
 .PHONY: cross
 cross: out/minikube-linux-amd64 out/minikube-darwin-amd64 out/minikube-windows-amd64.exe
@@ -350,6 +360,11 @@ release-iso: minikube_iso checksum
 	gsutil cp out/minikube.iso gs://$(ISO_BUCKET)/minikube-$(ISO_VERSION).iso
 	gsutil cp out/minikube.iso.sha256 gs://$(ISO_BUCKET)/minikube-$(ISO_VERSION).iso.sha256
 
+.PHONY: release-minikube
+release-minikube: out/minikube checksum
+	gsutil cp out/minikube-$(GOOS)-$(GOARCH) $(MINIKUBE_UPLOAD_LOCATION)/$(MINIKUBE_VERSION)/minikube-$(GOOS)-$(GOARCH)
+	gsutil cp out/minikube-$(GOOS)-$(GOARCH).sha256 $(MINIKUBE_UPLOAD_LOCATION)/$(MINIKUBE_VERSION)/minikube-$(GOOS)-$(GOARCH).sha256
+
 out/docker-machine-driver-kvm2.d:
 	$(MAKEDEPEND) out/docker-machine-driver-kvm2 $(ORG) $(KVM_DRIVER_FILES) $^ > $@