Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support SSL for connected services #88

Closed
Hampo opened this issue Jan 4, 2024 · 1 comment
Closed

[Feature] Support SSL for connected services #88

Hampo opened this issue Jan 4, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Hampo
Copy link

Hampo commented Jan 4, 2024

Is your feature request related to a problem? Please describe.
The URL for connected services assumes http, however I have Sonarr and Radarr on https with an SSL cert.

Describe the solution you'd like
Change Lidarr, Radarr and Sonarr's config to support a yaml entry like address: "https://radarr.example.com".

@Hampo Hampo added the enhancement New feature or request label Jan 4, 2024
@aetaric
Copy link
Owner

aetaric commented Jan 11, 2024

I will not change the lines to support using a URL as an "address", but I did change it to swap the http to https based on an SSL option.

Changing it to a URL would be a breaking change, while defaulting to current behavior and adding an SSL option is much easier on users that blindly update without checking the release notes.

Hopefully this is a middle ground that will still work for your needs, but will be less intrusive of a change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants