fixed weight assignment when computing leading edge #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Indeed, this looks like a sorting problem with the original code. Thanks for spotting this and making a patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weights of genes in final regulons didn't match the weights from the regression (adjacencies data frame).
The problem is when we compute the leading edge, where genes are sorted by ranking for pruning. Then, when we assign them the weights back, weights are sorted by alphabetical order. This leads to a gene-weight mismatch.
The leading_edge function in the recovery.py file was modified, so the weights get also sorted by ranking and the weight assignment now is fixed.