Skip to content

Fix for Expression Test #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhecking merged 3 commits into from
Jan 26, 2021
Merged

Fix for Expression Test #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c644c38
Fixed device Size test for not in-memory namespaces (#91)
jonas32 Jan 25, 2021
42c5100
Fixed HLL returns in tests
jonas32 Jan 25, 2021
731b133
Lowered ms on since_update to prevent failing
jonas32 Jan 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions tests/src/exp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,16 @@ fn expression_rec_ops() {
le(device_size(), int_val(0)),
&set_name,
);
let count = count_results(rs);
let mut count = count_results(rs);

if count == 0 {
// Not in-memory
let rs = test_filter(
le(device_size(), int_val(2000)),
&set_name,
);
count = count_results(rs);
}
assert_eq!(count, 100, "DEVICE SIZE Test Failed");

let rs = test_filter(
Expand All @@ -251,7 +260,7 @@ fn expression_rec_ops() {
assert_eq!(count, 100, "LAST UPDATE Test Failed");

let rs = test_filter(
gt(since_update(), int_val(150)),
gt(since_update(), int_val(10)),
&set_name,
);
let count = count_results(rs);
Expand Down
6 changes: 3 additions & 3 deletions tests/src/exp_hll.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ fn expression_hll() {
&set_name,
);
let count = count_results(rs);
assert_eq!(count, 98, "HLL INIT Test Failed");
assert_eq!(count, 99, "HLL INIT Test Failed");

let rs = test_filter(
eq(
Expand Down Expand Up @@ -125,7 +125,7 @@ fn expression_hll() {
&set_name,
);
let count = count_results(rs);
assert_eq!(count, 97, "HLL GET UNION Test Failed");
assert_eq!(count, 98, "HLL GET UNION Test Failed");

let rs = test_filter(
eq(
Expand All @@ -138,7 +138,7 @@ fn expression_hll() {
&set_name,
);
let count = count_results(rs);
assert_eq!(count, 97, "HLL GET UNION COUNT Test Failed");
assert_eq!(count, 98, "HLL GET UNION COUNT Test Failed");

let rs = test_filter(
eq(
Expand Down