regenerated auth and kv protobuf go files and deleted outdated ones #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@conradsmi Thanks for the steps to repro your results. Due to security concerns, I did not merge your PR (it's really hard to verify generated code), but I used your steps to generate the code again on my end. The issue should be resolved now in the v7.2.0 release. I'll close this ticket, but feel free to reopen it in case the issue is not mitigated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerated files via
protoc --proto_path=auth auth/*.proto --go_out=auth --go_opt=paths=source_relativeandprotoc --proto_path=kvs kvs/*.proto --go_out=kvs --go_opt=paths=source_relativeforproto/aerospike_proxy_auth.protoandproto/aerospike_proxy_kv.proto, respectively.This should resolve #414, as
proto/aerospike_proxy_auth_grpc.pb.goandproto/aerospike_proxy_kv_grpc.pb.gowere regenerated as a part of a previous fix, but the non-grpc ones were seemingly skipped over.If this is approved and merged, another PR should apply the fix to v6 as well.