Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency ws to 7.4.6 [security] #159

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 30, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change
ws 7.4.4 -> 7.4.6

GitHub Vulnerability Alerts

CVE-2021-32640

Impact

A specially crafted value of the Sec-Websocket-Protocol header can be used to significantly slow down a ws server.

Proof of concept

for (const length of [1000, 2000, 4000, 8000, 16000, 32000]) {
  const value = 'b' + ' '.repeat(length) + 'x';
  const start = process.hrtime.bigint();

  value.trim().split(/ *, */);

  const end = process.hrtime.bigint();

  console.log('length = %d, time = %f ns', length, end - start);
}

Patches

The vulnerability was fixed in [email protected] (websockets/ws@00c425e) and backported to [email protected] (websockets/ws@78c676d) and [email protected] (websockets/ws@76d47c1).

Workarounds

In vulnerable versions of ws, the issue can be mitigated by reducing the maximum allowed length of the request headers using the --max-http-header-size=size and/or the maxHeaderSize options.

Credits

The vulnerability was responsibly disclosed along with a fix in private by Robert McLaughlin from University of California, Santa Barbara.


Configuration

📅 Schedule: "" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@coveralls
Copy link

coveralls commented May 30, 2021

Pull Request Test Coverage Report for Build 899264943

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 62.097%

Totals Coverage Status
Change from base Build 899264836: 0.0%
Covered Lines: 128
Relevant Lines: 180

💛 - Coveralls

@renovate renovate bot changed the title chore(deps): update dependency ws to 7.4.6 [security] chore(deps): update dependency ws to 7.4.6 [security] - autoclosed Jun 1, 2021
@renovate renovate bot closed this Jun 1, 2021
@renovate renovate bot deleted the renovate/npm-ws-vulnerability branch June 1, 2021 21:09
@renovate renovate bot changed the title chore(deps): update dependency ws to 7.4.6 [security] - autoclosed chore(deps): update dependency ws to 7.4.6 [security] Jun 2, 2021
@renovate renovate bot restored the renovate/npm-ws-vulnerability branch June 2, 2021 11:57
@renovate renovate bot reopened this Jun 2, 2021
@renovate renovate bot force-pushed the renovate/npm-ws-vulnerability branch from e903ffd to 008d3bb Compare June 2, 2021 11:58
@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ziccardi ziccardi merged commit b7c32a0 into master Jun 17, 2021
@ziccardi ziccardi deleted the renovate/npm-ws-vulnerability branch June 17, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants