This repository was archived by the owner on Dec 18, 2019. It is now read-only.
feat(Add specific watch namespaces) : Impl workaround in Reconcile (AEROGEAR-9089)#57
Merged
camilamacedo86 merged 1 commit intoaerogear:masterfrom May 9, 2019
camilamacedo86:AEROGEAR-9089
Merged
feat(Add specific watch namespaces) : Impl workaround in Reconcile (AEROGEAR-9089)#57camilamacedo86 merged 1 commit intoaerogear:masterfrom camilamacedo86:AEROGEAR-9089
camilamacedo86 merged 1 commit intoaerogear:masterfrom
camilamacedo86:AEROGEAR-9089
Conversation
Contributor
Author
|
We decided to move with this workarround until the change made in the follow PR be available to us: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
davidffrench
reviewed
May 8, 2019
Member
davidffrench
left a comment
There was a problem hiding this comment.
Excellent work @camilamacedo86 . Just a few comments.
Contributor
Author
|
Hi @davidffrench, I believe that it is now as you wish. Note. When the namespace is valid has a log in its success and when it is invalid the error is though in the logs. If you believe that still something that needs to get done here, could you please ping me. Let's chat for I am able to understand what you re looking for. |
Member
|
@camilamacedo86 Since this should be a temporary solution, lets not worry about it. This is great work, approved now. |
davidffrench
approved these changes
May 9, 2019
Contributor
Author
|
Hi @davidffrench, Really thank you for your time and review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
https://issues.jboss.org/browse/AEROGEAR-9089
What
v0.1.10tov0.2.0-beta.1operator-framework/operator-sdk#1388 be merged and we are able to attend this need properly.Why
How
Verification Steps
docker.io/cmacedo/mobile-security-service-operator:AEROGEAR-9089make create-allinside of this new namespaceChecklist:
Progress