Skip to content
This repository was archived by the owner on Dec 18, 2019. It is now read-only.

feat(Add specific watch namespaces) : Impl workaround in Reconcile (AEROGEAR-9089)#57

Merged
camilamacedo86 merged 1 commit intoaerogear:masterfrom
camilamacedo86:AEROGEAR-9089
May 9, 2019
Merged

feat(Add specific watch namespaces) : Impl workaround in Reconcile (AEROGEAR-9089)#57
camilamacedo86 merged 1 commit intoaerogear:masterfrom
camilamacedo86:AEROGEAR-9089

Conversation

@camilamacedo86
Copy link
Copy Markdown
Contributor

@camilamacedo86 camilamacedo86 commented May 2, 2019

Motivation

https://issues.jboss.org/browse/AEROGEAR-9089

What

Why

  • Do not allow the operator apply the APP CR which is applied in a not specified namespace
  • Do not allow the mss CR and its database be applied in a namespace which is not the same of the operator.

How

  • Doing a check on reconciling to not allow it works in a namespace that is not one of the lists defined in the ENV VAR.
  • Doing the same above check in the reconciling of the Service and DB CRs but by checking if is the operator namespace or not.

Verification Steps

Checklist:

  • Code has been tested locally by PR requester
  • Changes have been successfully verified by another team member

Progress

  • Finished task
  • [] TODO

@camilamacedo86 camilamacedo86 added the work in progress work in progress label May 3, 2019
@camilamacedo86 camilamacedo86 removed the work in progress work in progress label May 3, 2019
@camilamacedo86 camilamacedo86 changed the title feat(Add specific watch namespaces) : Impl feature and do related refec (AEROGEAR-9089) feat(Add specific watch namespaces) : Impl feature (AEROGEAR-9089) May 3, 2019
@camilamacedo86 camilamacedo86 reopened this May 7, 2019
@camilamacedo86
Copy link
Copy Markdown
Contributor Author

We decided to move with this workarround until the change made in the follow PR be available to us:
operator-framework/operator-sdk#1388
c/c @davidffrench

@davidffrench

This comment has been minimized.

@camilamacedo86

This comment has been minimized.

@camilamacedo86 camilamacedo86 changed the title feat(Add specific watch namespaces) : Impl feature (AEROGEAR-9089) feat(Add specific watch namespaces) : Impl workaround in Reconcile (AEROGEAR-9089) May 8, 2019
Copy link
Copy Markdown
Member

@davidffrench davidffrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @camilamacedo86 . Just a few comments.

Comment thread cmd/manager/main.go Outdated
Comment thread pkg/controller/mobilesecurityserviceapp/controller.go
Comment thread pkg/controller/mobilesecurityservice/controller.go Outdated
@camilamacedo86
Copy link
Copy Markdown
Contributor Author

Hi @davidffrench,

I believe that it is now as you wish. Note. When the namespace is valid has a log in its success and when it is invalid the error is though in the logs. If you believe that still something that needs to get done here, could you please ping me. Let's chat for I am able to understand what you re looking for.

@davidffrench
Copy link
Copy Markdown
Member

@camilamacedo86 Since this should be a temporary solution, lets not worry about it. This is great work, approved now.

@camilamacedo86
Copy link
Copy Markdown
Contributor Author

Hi @davidffrench,

Really thank you for your time and review.

@camilamacedo86 camilamacedo86 merged commit c647795 into aerogear:master May 9, 2019
@camilamacedo86 camilamacedo86 deleted the AEROGEAR-9089 branch May 9, 2019 08:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants