add startup parameters to config log (#400)

Signed-off-by: wangshuide <[email protected]>
Co-authored-by: wangshuide2020 <[email protected]>

cmd/aeraki/main.go

@@ -15,7 +15,6 @@
 package main
 
 import (
-	"flag"
 	"os"
 	"os/signal"
 	"strings"
@@ -24,6 +23,8 @@ import (
 	"github.com/google/uuid"
 	"istio.io/pkg/log"
 
+	flag "github.com/spf13/pflag"
+
 	"github.com/aeraki-mesh/aeraki/internal/bootstrap"
 	"github.com/aeraki-mesh/aeraki/internal/config/constants"
 	"github.com/aeraki-mesh/aeraki/internal/envoyfilter"
@@ -63,6 +64,8 @@ func main() {
 	flag.StringVar(&args.KubeDomainSuffix, "domain", defaultKubernetesDomain, "Kubernetes DNS domain suffix")
 	flag.StringVar(&args.HTTPSAddr, "httpsAddr", ":15017", "validation service HTTPS address")
 	flag.StringVar(&args.HTTPAddr, "httpAddr", ":8080", "Aeraki readiness service HTTP address")
+	loggingOptions := log.DefaultOptions()
+	loggingOptions.AttachFlags(flag.StringArrayVar, flag.StringVar, flag.IntVar, flag.BoolVar)
 	flag.Parse()
 
 	flag.VisitAll(func(flag *flag.Flag) {
@@ -77,6 +80,9 @@ func main() {
 	log.Infof("Aeraki bootstrap parameter: %v", args)
 
 	setLogLevels(args.LogLevel)
+	if err := log.Configure(loggingOptions); err != nil {
+		log.Error("Failed to init Aeraki log: %v", err)
+	}
 	// Create the stop channel for all of the servers.
 	stopChan := make(chan struct{}, 1)
 	args.Protocols = initGenerators()

docker/Dockerfile

@@ -26,4 +26,4 @@ RUN apk update && \
     apk add curl
 
 COPY ${AERAKI_ROOT_BIN_DIR}/${ARCH}/${OS}/aeraki /usr/local/bin/
-ENTRYPOINT /usr/local/bin/aeraki
+ENTRYPOINT ["/usr/local/bin/aeraki"]

go.mod

@@ -37,6 +37,7 @@ require (
 	github.com/google/uuid v1.3.0
 	github.com/hashicorp/go-multierror v1.1.1
 	github.com/pkg/errors v0.9.1
+	github.com/spf13/pflag v1.0.5
 	github.com/zhaohuabing/debounce v1.0.0
 	go.uber.org/atomic v1.11.0
 	golang.org/x/net v0.17.0
@@ -169,7 +170,6 @@ require (
 	github.com/spaolacci/murmur3 v1.1.0 // indirect
 	github.com/spf13/cast v1.5.1 // indirect
 	github.com/spf13/cobra v1.7.0 // indirect
-	github.com/spf13/pflag v1.0.5 // indirect
 	github.com/stoewer/go-strcase v1.3.0 // indirect
 	github.com/stretchr/testify v1.8.4 // indirect
 	github.com/vbatts/tar-split v0.11.3 // indirect

k8s/aeraki.yaml

@@ -37,9 +37,10 @@ spec:
         - name: aeraki
           image: ${AERAKI_IMAGE}:${AERAKI_TAG}
           args:
-            - /usr/local/bin/aeraki
             - --master=true
             - --enable-envoy-filter-namespace-scope=false
+            - --log_output_level=all:info
+            - --log_rotate=/home/aeraki_run.log
           # imagePullPolicy should be set to Never so Minikube can use local image for e2e testing
           imagePullPolicy: ${AERAKI_IMG_PULL_POLICY}
           ports: