-
Notifications
You must be signed in to change notification settings - Fork 208
[ENH] Adds RED CoMETS classifier #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
great, thanks Luca. The categories are necessarily fluid, but I would probably put it in dictionary based? |
also, would you like to join our slack @zy18811 https://join.slack.com/t/aeon-toolkit/shared_invite/zt-2466yn6zm-5fV0EW8JjSVUoe2hzJjRMw |
could you add some testing code for this? You can use skip test for the soft dependency, for example, someting like this before each test function @pytest.mark.skipif(
not _check_soft_dependencies("imblearn", severity="none"),
reason="skip test if required soft dependency esig not available",
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of very minor docstring comments, but otherwise this looks great, thank you for the contribution
this test failure is nothing to do with your PR, just a weird tensorflow thing |
Think I've addressed the two docstring issues :) 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more tiny thing on the soft dependencies and I think its ready, great job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Luca, thanks for the contribution. Great work.
One minor change to the all-contributors file would be good, I can monitor and merge after that is complete unless anyone else wants to review and request changes.
df51a5f
PR adding RED CoMETS classifier.
Not sure what algorithm type it falls under? So have put into hybrid for now.
Adds a soft dependency to imbalanced-learn.
TODO
PR checklist