Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Remove test exclusions #2409

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[ENH] Remove test exclusions #2409

wants to merge 6 commits into from

Conversation

TonyBagnall
Copy link
Contributor

new testing identified estimators that changed state in predict or transform. This was due to saving data in predict/transform to self.some_variable. Changed a couple to not store this data. If storing is required, it should be done in fit

@aeon-actions-bot aeon-actions-bot bot added enhancement New feature, improvement request or other non-bug code enhancement segmentation Segmentation package testing Testing related issue or pull request transformations Transformations package labels Nov 27, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#0e8a16}{\textsf{segmentation}}$, $\color{#2C2F20}{\textsf{testing}}$, $\color{#41A8F6}{\textsf{transformations}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

@TonyBagnall TonyBagnall marked this pull request as draft November 27, 2024 14:48
@TonyBagnall TonyBagnall marked this pull request as ready for review November 28, 2024 20:01
Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good chunk removed

@@ -116,7 +116,7 @@ def fit(self, X, y=None, axis=1):
self.reset()
if axis is None: # If none given, assume it is correct.
axis = self.axis
X = self._preprocess_series(X, axis, True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fine for fit? Think thats the metadata param but may be wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, improvement request or other non-bug code enhancement segmentation Segmentation package testing Testing related issue or pull request transformations Transformations package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants