-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Remove test exclusions #2409
base: main
Are you sure you want to change the base?
Conversation
Thank you for contributing to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good chunk removed
@@ -116,7 +116,7 @@ def fit(self, X, y=None, axis=1): | |||
self.reset() | |||
if axis is None: # If none given, assume it is correct. | |||
axis = self.axis | |||
X = self._preprocess_series(X, axis, True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fine for fit
? Think thats the metadata param but may be wrong
new testing identified estimators that changed state in predict or transform. This was due to saving data in predict/transform to self.some_variable. Changed a couple to not store this data. If storing is required, it should be done in fit