Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] remove redundant soft dependency checks #2101

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

SebastianSchmidl
Copy link
Member

Reference Issues/PRs

none, but inspired by this PR comment

What does this implement/fix? Explain your changes.

  • removes redundant calls to _check_soft_dependencies in estimators (this is already done by the __init__-function of the base classes
  • adds the correct version bound for pyod in PyODAdapter since a new version with the pyod.__version__-attribute was published

Does your contribution introduce a new dependency? If yes, which one?

no

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.

@SebastianSchmidl SebastianSchmidl added maintenance Continuous integration, unit testing & package distribution dependencies This issue or PR is related to dependencies of aeon labels Sep 26, 2024
@SebastianSchmidl SebastianSchmidl self-assigned this Sep 26, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

This PR changes too many different packages (>3) for automatic addition of labels, please manually add package labels if relevant.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Push an empty commit to re-run CI checks

Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have of question on pyod but LGTM if you want to keep it as is.

aeon/clustering/_k_shapes.py Outdated Show resolved Hide resolved
aeon/anomaly_detection/_pyodadapter.py Outdated Show resolved Hide resolved
Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TonyBagnall TonyBagnall merged commit 005121b into main Sep 30, 2024
15 checks passed
@TonyBagnall TonyBagnall deleted the mnt/redundant-soft-dep-calls branch September 30, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies This issue or PR is related to dependencies of aeon maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants