-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT] remove redundant soft dependency checks #2101
Conversation
Thank you for contributing to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have of question on pyod
but LGTM if you want to keep it as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Reference Issues/PRs
none, but inspired by this PR comment
What does this implement/fix? Explain your changes.
_check_soft_dependencies
in estimators (this is already done by the__init__
-function of the base classespyod
inPyODAdapter
since a new version with thepyod.__version__
-attribute was publishedDoes your contribution introduce a new dependency? If yes, which one?
no
PR checklist
For all contributions