Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Implemented MockCluster in testing module #2029

Merged

Conversation

notaryanramani
Copy link
Contributor

@notaryanramani notaryanramani commented Sep 4, 2024

Reference Issues/PRs

Fixes #1529

What does this implement/fix? Explain your changes.

Implements MockCluster class inline with classification and regression, along with test cases.

Does your contribution introduce a new dependency? If yes, which one?

No

Any other comments?

No

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you. --> Will do this after this PR is reviewed
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.

@aeon-actions-bot aeon-actions-bot bot added clustering Clustering package testing Testing related issue or pull request labels Sep 4, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I did not find any labels to add based on the title. Please add the [ENH], [MNT], [BUG], [DOC], [REF], [DEP] and/or [GOV] tags to your pull requests titles. For now you can add the labels manually.
I have added the following labels to this PR based on the changes made: [ $\color{#4011F3}{\textsf{clustering}}$, $\color{#2C2F20}{\textsf{testing}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Push an empty commit to re-run CI checks

@notaryanramani notaryanramani changed the title [EHN] Implemented MockCluster in testing module [ENH] Implemented MockCluster in testing module Sep 4, 2024
@notaryanramani notaryanramani marked this pull request as ready for review September 4, 2024 12:03
@chrisholder
Copy link
Contributor

LGTM! Thanks for the addition!

@TonyBagnall TonyBagnall merged commit f365bfe into aeon-toolkit:main Sep 12, 2024
14 checks passed
@notaryanramani notaryanramani deleted the notaryanramani/issue1529 branch September 12, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clustering Clustering package testing Testing related issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Implement MockClusterer
3 participants