Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Fixes mis-wording/typo in mentoring docs #1396

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

wayneadams
Copy link
Contributor

@wayneadams wayneadams commented Apr 10, 2024

What does this implement/fix? Explain your changes.

These changes fix what looks to be mis-wording/typos in mentoring docs. Though, I'm not 100% sure what the intention was, so this PR is just to start the editing process.

Does your contribution introduce a new dependency? If yes, which one?

No

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.

@aeon-actions-bot aeon-actions-bot bot added the documentation Improvements or additions to documentation label Apr 10, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#F3B9F8}{\textsf{documentation}}$ ].

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

@wayneadams
Copy link
Contributor Author

@all-contributors please add @wayneadams for doc

Copy link
Contributor

@wayneadams

I've put up a pull request to add @wayneadams! 🎉

@baraline
Copy link
Member

Hi, thanks and nice spot ! Tell us when you are done with the editting so we can review.

@wayneadams
Copy link
Contributor Author

@baraline , I'm done editing and the PR is ready for review.

Copy link
Member

@baraline baraline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small typo, otherwise looking good and in line with the other projects, thanks again !

@wayneadams wayneadams requested a review from baraline April 11, 2024 13:38
Copy link
Member

@baraline baraline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@baraline baraline merged commit 8b5c020 into aeon-toolkit:main Apr 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants