Symfony 6 support #355
Merged
Symfony 6 support #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated composer.json to add SF ^6.0 - Add interfaced type hints - Pass FormFactoryInterface to holiday controller & only use container access on SF 4.4 - Create \Aeon\Symfony\AeonBundle\DependencyInjection\Loader\Configurator\LegacyConfigurator to wrap ref() deprecation/removal - Change ref() to service() - symfony/dependency-injection minimum ^5.1 - symfony/form minimum ^5.3
|
Thank you for the contribution @GwendolenLynch! |
GwendolenLynch
force-pushed
the
symfony-6
branch
from
5439fa2
to
481a4c9
Compare
|
You're most welcome, @norberttech 😺 With coffee in hand I did some research and local testing, and it seems that:
Let's see what CI thinks. |
GwendolenLynch
force-pushed
the
symfony-6
branch
from
481a4c9
to
088e38c
Compare
|
Also, after looking into your question about Composer plugins in aeon-php/rate-limiter#63, I have removed the config change in this PR as well. |
norberttech
reviewed
Jun 19, 2022
GwendolenLynch
force-pushed
the
symfony-6
branch
3 times, most recently
from
eaf6d03
to
4474fa3
Compare
|
I can't docblock some days. I've added the missing |
|
Thanks ✌️🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log
Added
Fixed
Changed
ref()toservice()symfony/dependency-injectionminimum version^5.1symfony/framework-bundle(dev) minimum version^5.3symfony/formminimum version^5.3Updated
FormFactoryInterfacetoholidaycontroller & remove container accessRemoved
Deprecated
Security
Description
This PR updates the bundle for Symfony 6.