Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse common labels #89

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Reuse common labels #89

merged 3 commits into from
Mar 28, 2024

Conversation

ilya-hontarau
Copy link
Contributor

No description provided.

sergeyshevch
sergeyshevch requested changes Mar 27, 2024
View reviewed changes
Copy link
Member

@sergeyshevch sergeyshevch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Can you please add some tests that will cover that builder will works correctly. It will help us to support this code in future

I enabled tests run for this PR

@sergeyshevch sergeyshevch added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 27, 2024
sergeyshevch
sergeyshevch approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@sergeyshevch sergeyshevch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

sircthulhu
sircthulhu approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@sircthulhu sircthulhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sircthulhu sircthulhu merged commit fee8e09 into aenix-io:main Mar 28, 2024
3 checks passed
@sircthulhu sircthulhu added the enhancement New feature or request label Mar 29, 2024
@kvaps kvaps added this to the v0.1.0 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyshevch sergeyshevch sergeyshevch approved these changes

@sircthulhu sircthulhu sircthulhu approved these changes

@Kirill-Garbar Kirill-Garbar Awaiting requested review from Kirill-Garbar Kirill-Garbar is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
etcd-operator
Status: Done
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ilya-hontarau @sircthulhu @sergeyshevch @kvaps