Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate extraArgs field in kind:EtcdCluster #77

Closed
sergeyshevch opened this issue Mar 23, 2024 · 5 comments · Fixed by #99
Closed

Validate extraArgs field in kind:EtcdCluster #77

sergeyshevch opened this issue Mar 23, 2024 · 5 comments · Fixed by #99
Assignees
@andreykont
Labels
help wanted Extra attention is needed
Milestone
v0.1.0

Comments

@sergeyshevch
Copy link
Member

sergeyshevch commented Mar 23, 2024 •
edited
Loading

We should validate extraArgs field and prevent usage of args generated by operator itself.
Follow up for #72 #69
@sergeyshevch sergeyshevch added the help wanted Extra attention is needed label Mar 25, 2024
@sircthulhu
Copy link
Member

sircthulhu commented Mar 26, 2024 •
edited
Loading

Should we check that etcd supports such flags or just reject collisions with flags used by the operator?

@sergeyshevch
Copy link
Member Author

The initial request was just to reject collisions. I guess it will be enough for now

@andreykont
Copy link
Contributor

Which of 3 behavior we want:

  1. Validation web hook
  2. status error
  3. skip the unwanted argument

@sergeyshevch
Copy link
Member Author

I guess validation webhook error

@andreykont
Copy link
Contributor

andreykont commented Mar 31, 2024 •
edited
Loading

#99

@kvaps kvaps added this to the v0.0.3 milestone Mar 31, 2024
@sergeyshevch sergeyshevch mentioned this issue Apr 1, 2024
Merged
sircthulhu pushed a commit that referenced this issue Apr 3, 2024
@andreykont @sergeyshevch
feat: validate extraargs (#99)
09f0e5a 
Closes: #77

---------

Co-authored-by: Andrey Kontyakov <[email protected]>
Co-authored-by: Sergey Shevchenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreykont andreykont

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

Feature/77 validate extraargs andreykont/etcd-operator
4 participants
@sircthulhu @kvaps @sergeyshevch @andreykont