New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nilaway, check in pre-commit #174

Closed

hiddenmarten opened this issue Apr 14, 2024 · 0 comments · Fixed by #184

Member

hiddenmarten commented Apr 14, 2024 •

edited

Loading

Add https://github.com/uber-go/nilaway as a plugin for golanci-lint.

https://github.com/uber-go/nilaway?tab=readme-ov-file#golangci-lint

mneverov mentioned this issue

Add nilaway linter. #184

Merged

sircthulhu closed this as completed in #184

sircthulhu pushed a commit that referenced this issue


          Add nilaway linter. (#184)

b6e8f5a

Closes #174.

Without specifying packages the linter consume all memory when trying to
parse `site` and other directories.
I excluded `cmd` package because the linter complained on using
[mgr](https://github.com/aenix-io/etcd-operator/blob/main/cmd/main.go#L126)
even if it cannot be nil since the error that is returned from the
manager constructer is checked.

Co-authored-by: Oleg Kunitsyn <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment