Ignore COM812 rule #410
Open
Ignore COM812 rule #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #410 +/- ##
=======================================
Coverage 80.44% 80.44%
=======================================
Files 86 86
Lines 5795 5795
=======================================
Hits 4662 4662
Misses 1133 1133 ☔ View full report in Codecov by Sentry. |
julien4215
force-pushed
the
remove-COM812-rule
branch
from
8e6ed23
to
9a43834
Compare
armanddidierjean
pushed a commit
that referenced
this pull request
May 4, 2024
Bumps [pytest-mock](https://github.com/pytest-dev/pytest-mock) from 3.12.0 to 3.14.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/pytest-dev/pytest-mock/releases">pytest-mock's releases</a>.</em></p> <blockquote> <h2>v3.14.0</h2> <ul> <li><a href="https://github.com/pytest-dev/pytest-mock/pull/415">#415</a>: <code>MockType</code> and <code>AsyncMockType</code> can be imported from <code>pytest_mock</code> for type annotation purposes.</li> <li><a href="https://github.com/pytest-dev/pytest-mock/issues/420">#420</a>: Fixed a regression which would cause <code>mocker.patch.object</code> to not being properly cleared between tests.</li> </ul> <h2>v3.13.0</h2> <ul> <li><a href="https://github.com/pytest-dev/pytest-mock/pull/417">#417</a>: <code>spy</code> now has <code>spy_return_list</code>, which is a list containing all the values returned by the spied function.</li> <li><code>pytest-mock</code> now requires <code>pytest>=6.2.5</code>.</li> <li><a href="https://github.com/pytest-dev/pytest-mock/pull/410">#410</a>: pytest-mock's <code>setup.py</code> file is removed. If you relied on this file, e.g. to install pytest using <code>setup.py install</code>, please see <a href="https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html#summary">Why you shouldn't invoke setup.py directly</a> for alternatives.</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pytest-dev/pytest-mock/blob/main/CHANGELOG.rst">pytest-mock's changelog</a>.</em></p> <blockquote> <h2>3.14.0 (2024-03-21)</h2> <ul> <li> <p><code>[#415](pytest-dev/pytest-mock#415) <https://github.com/pytest-dev/pytest-mock/pull/415></code>_: <code>MockType</code> and <code>AsyncMockType</code> can be imported from <code>pytest_mock</code> for type annotation purposes.</p> </li> <li> <p><code>[#420](pytest-dev/pytest-mock#420) <https://github.com/pytest-dev/pytest-mock/issues/420></code>_: Fixed a regression which would cause <code>mocker.patch.object</code> to not being properly cleared between tests.</p> </li> </ul> <h2>3.13.0 (2024-03-21)</h2> <ul> <li><code>[#417](pytest-dev/pytest-mock#417) <https://github.com/pytest-dev/pytest-mock/pull/417></code>_: <code>spy</code> now has <code>spy_return_list</code>, which is a list containing all the values returned by the spied function.</li> <li><code>pytest-mock</code> now requires <code>pytest>=6.2.5</code>.</li> <li><code>[#410](pytest-dev/pytest-mock#410) <https://github.com/pytest-dev/pytest-mock/pull/410></code><em>: pytest-mock's <code>setup.py</code> file is removed. If you relied on this file, e.g. to install pytest using <code>setup.py install</code>, please see <code>Why you shouldn't invoke setup.py directly <https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html#summary></code></em> for alternatives.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/8733134b6194395e9cd3c745adcc9a9c09b0279e"><code>8733134</code></a> Update CHANGELOG for 3.14.0</li> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/5257e3c0df0a18bca4028daa9e6d2d91870ff576"><code>5257e3c</code></a> Refactor MockCache to have a narrow interface</li> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/4faf92ae233afadac3831ab570531e540dc87830"><code>4faf92a</code></a> Fix regression with mocker.patch not being undone correctly</li> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/6bd8712a14a1a11d348354318fdbad3fd9bbdb78"><code>6bd8712</code></a> Drop pre-Python 3.8 support code</li> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/366966bff1e3ca2e1455d704dd59991da5593877"><code>366966b</code></a> Export <code>MockType</code>/<code>AsyncMockType</code> for type annotations (<a href="https://github.com/pytest-dev/pytest-mock/issues/415">#415</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/852116b0af33db27fe595847c091631dcf059a1c"><code>852116b</code></a> Merge pull request <a href="https://github.com/pytest-dev/pytest-mock/issues/418">#418</a> from pytest-dev/release-3.13.0</li> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/ef9461b8b5bdcdd416841b986cf4e1d336c84266"><code>ef9461b</code></a> Add instructions on how to start deploy from command-line</li> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/5b9d2858f507e04cc97a3c206f55d7d5505ae71c"><code>5b9d285</code></a> Release 3.13.0</li> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/6d5d6dc2274cea96b6919a4a2a6dc7a3394ef11d"><code>6d5d6dc</code></a> Implement <code>spy_return_list</code> (<a href="https://github.com/pytest-dev/pytest-mock/issues/417">#417</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/dc28a0ec7b66372fbc6e0cf1bbe443ce7ca465cd"><code>dc28a0e</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://github.com/pytest-dev/pytest-mock/issues/416">#416</a>)</li> <li>Additional commits viewable in <a href="https://github.com/pytest-dev/pytest-mock/compare/v3.12.0...v3.14.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Rotheem
approved these changes
Jul 18, 2024
|
Related issue: astral-sh/ruff#9216 Personally, I would be in favor of keeping COM812, even if it's tagged as conflicting with the formatter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a rule that is conflicting with the formatter