Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

内部のメディアプロキシ・サマリープロキシの動作を変更 #363

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

adzukimame
Copy link
Owner

What

  • 内部サマリープロキシを廃止
  • production環境では内部メディアプロキシを動作させない

Why

Additional info (optional)

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 10.52632% with 17 lines in your changes missing coverage. Please review.

Project coverage is 43.78%. Comparing base (d59d8a2) to head (3c2ec2f).
Report is 1 commits behind head on develop-mame.

Files with missing lines Patch % Lines
packages/backend/src/server/FileServerService.ts 0.00% 14 Missing ⚠️
...ckages/backend/src/server/web/UrlPreviewService.ts 33.33% 2 Missing ⚠️
packages/frontend/src/scripts/media-proxy.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           develop-mame     #363   +/-   ##
=============================================
  Coverage         43.77%   43.78%           
=============================================
  Files              1169     1169           
  Lines            147821   147800   -21     
  Branches           3438     3438           
=============================================
- Hits              64715    64713    -2     
+ Misses            83106    83087   -19     
Flag Coverage Δ
backend_e2e 55.40% <5.88%> (+0.01%) ⬆️
backend_unit 27.86% <0.00%> (+<0.01%) ⬆️
frontend_vitest 26.04% <50.00%> (-0.01%) ⬇️
misskey-js 92.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 11, 2024

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@adzukimame adzukimame merged commit e06fd64 into develop-mame Dec 11, 2024
38 checks passed
@adzukimame adzukimame deleted the remove-internal-proxies branch December 11, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant