Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick: fix weird AP delivered chart in control panel #231

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

adzukimame
Copy link
Owner

What

  • fix(frontend): weird AP delivered chart in control panel (# 14481)

Why

Additional info (optional)

* fix(frontend): `Out: Fail` was negative number

* fix(frontend): don't stack AP delivered chart

* test(misskey-dev#10336): add `pages/admin/overview.ap-requests.vue` story

* Update CHANGELOG.md

---------

Co-authored-by: syuilo <[email protected]>
@adzukimame adzukimame enabled auto-merge (squash) November 5, 2024 05:36
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 42.86%. Comparing base (fd9fe56) to head (b2d815f).
Report is 1 commits behind head on develop-mame.

Files with missing lines Patch % Lines
.../frontend/src/pages/admin/overview.ap-requests.vue 0.00% 7 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           develop-mame     #231      +/-   ##
================================================
- Coverage         42.86%   42.86%   -0.01%     
================================================
  Files              1258     1258              
  Lines            158380   158381       +1     
  Branches           3143     3143              
================================================
  Hits              67897    67897              
- Misses            90483    90484       +1     
Flag Coverage Δ
frontend_vitest 23.96% <0.00%> (-0.01%) ⬇️
misskey-js 92.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adzukimame adzukimame merged commit ba8140c into develop-mame Nov 5, 2024
21 checks passed
@adzukimame adzukimame deleted the fix-ap-deliver-chart-control-panel branch November 5, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants