Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kevel/lmdb 0.9.29 #1

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Kevel/lmdb 0.9.29 #1

wants to merge 16 commits into from

Conversation

matttylr
Copy link
Collaborator

No description provided.

Copy link

@shooit shooit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good. I agree we will want to spend some more time with how we handle transactions but we can come back to that especially if we aren't getting burned by the cost to open a transaction.

store.js Outdated Show resolved Hide resolved
store.js Outdated Show resolved Hide resolved
@matttylr
Copy link
Collaborator Author

This all looks good. I agree we will want to spend some more time with how we handle transactions but we can come back to that especially if we aren't getting burned by the cost to open a transaction.

@shooit Bifrost opens a single transaction per request and stores that in the AsyncLocalStorage context which the Store class looks for, so we're ok atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants