API PATCH /me/progress/:id - allow providing createdAt and respect provided finishedAt when syncing progress #3546
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to make a script to set some of my old read books to done, but to avoid screwing up the stats i wanted to set them on a previous year.
I noticed some issues however, and during my research I found that there are some issues when creating and updating
mediaProgress
createdAt
(orstartedAt
, as the api documentation states) was not respected at all at either during creation or update.finishedAt
was not respected during creation, but can be updated after the initial call.For the first issue, this allows
createdAt
to be set on creation but I could not figure out how to let it be updatable. My suspicion is that there is some magic going on which disallows the fieldcreatedAt
to be updated due to sequelize default timestamps on their models.For the second issue I just found where the
finishedAt
timestamp was overwritten on creation, and fixed the issue.