Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS option for filenames as episodes #2543

Closed
windsifter opened this issue Jan 22, 2024 · 5 comments
Closed

RSS option for filenames as episodes #2543

windsifter opened this issue Jan 22, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@windsifter
Copy link

Describe the feature/enhancement

Add an option to list audiobook RSS as filenames instead of the current mixture of chapters and filenames deepening on where the files align. Having a number / track in the title would also allow for easy sorting and to know the order / progress in a book.

Currently the Episode names are taken from Chapters if they align with the start of the file, but otherwise default to a file so it will be inconsistent throughout the feed. I've had this issue with every books I've tried. (abs view: https://i.imgur.com/gj7dSXp.png RSS feed view: https://i.imgur.com/sbn9Z6N.png)

Current relevant code: https://github.com/advplyr/audiobookshelf/blob/master/server%2Fobjects%2FFeedEpisode.js#L118-L127

@windsifter windsifter added the enhancement New feature or request label Jan 22, 2024
@advplyr
Copy link
Owner

advplyr commented Jan 22, 2024

A better solution might be to only use the chapter names if all audio files match timestamps with the chapters

@windsifter
Copy link
Author

Yes, that is true if all chapters align with file names. The worst scenario is a mixture of chapters and file names which is something I consistently get. But the other key item is adding a number as the first part of the episode name so you can sort or know if you are listening to the first or last episode. You may need to be smart or use 2 digits or you'll get 1, 11, 2, 3, etc

Thanks!

@advplyr
Copy link
Owner

advplyr commented Jan 23, 2024

We had this issue with using filenames as chapters I initially was prepending a number in front of the filename but most users already have a number in the filename so it was creating a duplicate number.
Here is the request for the mobile app repo advplyr/audiobookshelf-app#981. I couldn't find the original one for this repo but it was brought up a few times.

advplyr added a commit that referenced this issue Jan 23, 2024
@advplyr advplyr added the awaiting release Issue is resolved and will be in the next release label Jan 23, 2024
@advplyr
Copy link
Owner

advplyr commented Feb 20, 2024

Added in v2.8.0

@advplyr advplyr removed the awaiting release Issue is resolved and will be in the next release label Feb 20, 2024
@nichwall
Copy link
Contributor

Can this be closed?

@advplyr advplyr closed this as completed May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants