Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Separate library type for text (epub) books #2474

Closed
dathbe opened this issue Jan 2, 2024 · 4 comments
Closed

[Enhancement]: Separate library type for text (epub) books #2474

dathbe opened this issue Jan 2, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@dathbe
Copy link

dathbe commented Jan 2, 2024

Describe the feature/enhancement

The current library type of “books” should be changed to “audiobooks” and a new “books” type should be created. The UI for the current library type doesn’t really work for text books (e.g., “Continue Listening” should be “Continue Reading”). I’d also propose that rectangle cover art should be standard for text books. There may be other things to tweak between the two.

@dathbe dathbe added the enhancement New feature or request label Jan 2, 2024
@advplyr
Copy link
Owner

advplyr commented Jan 2, 2024

This would remove the option for storing abooks and ebooks together.

I prefer #2314 where we allow an ebook only setting similar to how we have an abook only setting. The alternative would be to have 3 library types, audiobook, ebook and book but that might be more confusing to people.

The "Continue Reading" shelf can still be supported even without a separate library type because we just check if the progress is from an ebook or abook. This was in a past version but I removed it temporarily until the database speed gets improved.

@dathbe
Copy link
Author

dathbe commented Jan 2, 2024

I defer to how you'd prefer to implement, but I was thinking that the abook type would still permit ebooks, it would just be "geared" toward abooks. I presume I could select my library being a podcast and it would still let me play abooks with relatively little difficulty...there are just a few tweaks that make them display and act different. All I'm suggesting is that there should be a way to specify the library is primarily ebooks instead of primarily abooks.

More particularly, I'm not suggesting any changes to the way the server implements an abooks library--other than the proposed renaming, but you could easily keep the name "books" and add a new name "text books" or "e-books". I don't really care what the library types are called as long as the documentation explains what each type does. But I do think it would be useful to have a text books library type. If that's accomplished through a toggle switch within the abooks type, so be it. Though I could see a few other types down the line, including digital comics.

@advplyr
Copy link
Owner

advplyr commented Jan 5, 2024

This will be a duplicate of #2314 for now but perhaps it is separated into a different media type. The problem is the data model would need to change to accommodate that whereas it wouldn't need to change if we did an e-book only setting.

@advplyr
Copy link
Owner

advplyr commented Jan 5, 2024

Duplicate of #2314

@advplyr advplyr marked this as a duplicate of #2314 Jan 5, 2024
@advplyr advplyr closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants