Fix catch exception on failed to parse comic metadata #3804

advplyr · Jan 8, 2025 · 02ecf7c · 02ecf7c
1 parent 05ff5f1
commit 02ecf7c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/server/utils/comicBookExtractors.js b/server/utils/comicBookExtractors.js
@@ -189,8 +189,14 @@ class CbzStreamZipComicBookExtractor extends AbstractComicBookExtractor {
   }
 
   close() {
-    this.archive?.close()
-    Logger.debug(`[CbzStreamZipComicBookExtractor] Closed comic book "${this.comicPath}"`)
+    this.archive
+      ?.close()
+      .then(() => {
+        Logger.debug(`[CbzStreamZipComicBookExtractor] Closed comic book "${this.comicPath}"`)
+      })
+      .catch((error) => {
+        Logger.error(`[CbzStreamZipComicBookExtractor] Failed to close comic book "${this.comicPath}"`, error)
+      })
   }
 }
 

diff --git a/server/utils/parsers/parseComicMetadata.js b/server/utils/parsers/parseComicMetadata.js
@@ -43,7 +43,9 @@ async function parse(ebookFile) {
     archive = createComicBookExtractor(comicPath)
     await archive.open()
 
-    const filePaths = await archive.getFilePaths()
+    const filePaths = await archive.getFilePaths().catch((error) => {
+      Logger.error(`[parseComicMetadata] Failed to get file paths from comic at "${comicPath}"`, error)
+    })
 
     // Sort the file paths in a natural order to get the first image
     filePaths.sort((a, b) => {