Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak the download page (add library size and play episode) #1235

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

mfcar
Copy link
Contributor

@mfcar mfcar commented Jun 11, 2024

Update the downloads page to include the adding:

  • Display the total library size.
  • Show sizes for each category (Audios, Episodes, Other Files).
  • Add a play button for each downloaded podcast episode.

Screenshot

Screenshot 2024-06-11 at 19 38 56

Demo (running on iPhone 13 iOS17)

RPReplay_Final1718130398.MP4

@advplyr
Copy link
Owner

advplyr commented Jun 12, 2024

I'm not sure how you were seeing a total size for the podcast episodes & audiobook audio tracks because those were not getting set. Maybe you had downloaded the podcast episode a long time ago when the scanner was still in use.

I updated the downloads to set the size data and it is working now. Previously downloaded media items aren't going to show a size though unfortunately.

@advplyr
Copy link
Owner

advplyr commented Jun 12, 2024

Thanks!

@advplyr advplyr merged commit ac8a2ca into advplyr:master Jun 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants