Fix bug iOS AudioPlayer where multiple calls to setupRemoteTransportC… #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontrols resulted in duplicate MPRemoteCommand targets being applied for the same action.
|
Works great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ontrols resulted in duplicate MPRemoteCommand targets being applied for the same action.
We call this multiple times to pick up settings changes for certain playback controls. This makes that safe, with the assumption that we don't actually ever want multiple targets defined on the same commandCenter action. If at some point we do want that, then we'll need to refactor this to do more state-management, but I figured it was better to start with the simple approach unless/until we need the more complex one.
Fixes #1141.