iOS Now Playing Chapter Track (updated #372) #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #239 |
38 tasks
|
This is working great in my tests. I had to make one fix when using the track in NowPlaying to seek. The only other part I'd like to improve on that is there is sometimes a 5 - 10 seconds delay when switching chapters before the NowPlaying is refreshed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is all of @ronaldheft's work from #372 tied into the chapter track setting of the webView player. The only thing I'm unsure about is whether the setChapterTrack route for AbsAudioPlayer needs to be implemented on the Android side as well. I don't have an Android to test whether the route being called causes any errors, but it compiles and works perfectly on iOS.