Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Sleep Timer modal defaults to "Custom Time" only during first access after app start #1224

Closed
nichwall opened this issue Jun 5, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@nichwall
Copy link
Contributor

nichwall commented Jun 5, 2024

What was the Problem?

The sleep timer in the mobile app defaults to "Custom Time" mode the first time the modal is opened after the app has been opened. After the sleep timer modal has been closed (either using back button or clicking out of modal) the Sleep Timer modal will default to the preset time view until the app is restarted.

Looks like this is due to 8201f3c defaulting to true instead of false.

Steps to Reproduce the Issue

  1. Open ABS app after having app completely closed
  2. Press sleep timer (observe sleep timer defaults to 1 minute of "custom time")
  3. Press back button or click out of modal to close
  4. Press sleep timer (observe defaults to "preset time" list until app is completely closed again)

What was Expected?

Sleep timer should default to "preset list" every time.

Phone Model

Pixel 6a

Phone OS

Android 14, stock

Audiobookshelf App Version

Android App - 0.9.74

Installation Source

Google Play Store

Additional Notes

No response

@m0veax
Copy link

m0veax commented Jun 30, 2024

It is the same on iOS

Version 0.97.4-Beta
iOS 17.5.1
iPhone 13

If I can provide any more infos, let me know

EDIT:

Sry, just saw the fix commit. Sry for making this issue noisy.

Thanks for your work, really enjoy your software

Copy link

Fixed in v0.9.75-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants