Use more standard representation of boolean values in cells #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://bugs.documentfoundation.org/show_bug.cgi?id=155046 Unfortunately the OOXML ECMA-376 spec does not ever seem to explicitly mention what is expected for a `<v>` element within a `<c> element with `t="b"`. But it seems that excel4node's writing the text "true" and "false" instead of the text "0" and "1" within `<v>` elements representing boolean values is uncommon behavior.
|
This looks good. I added additional boolean cells to the sample.js to verify the output: 4572571 Comparing the output from main to this pull request in google docs shows the correct values now being rendered. Left is current version, right is this pull request. LibreOffice Calc is also now rendering boolean true values correctly: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://bugs.documentfoundation.org/show_bug.cgi?id=155046
Unfortunately the OOXML ECMA-376 spec does not ever seem to explicitly mention what is expected for a
<v>cell value element within a<c>cell element wheret="b"indicates a boolean value type. But it seems that excel4node's writing the text "true" and "false" instead of the text "0" and "1" within<v>elements representing boolean values is uncommon behavior.With this change, boolean cells now display as expected in LibreOffice Calc and Google Sheets, where previously they did not.
I verified on my system that
npm run testandnode sample.js && ./validate.sh Excel.xlsxboth run successfully after building.This is an improved implementation of the same fix as in #59.