Impact
Kiwi TCMS allows users to upload attachments to test plans, test cases, etc. Earlier versions of Kiwi TCMS had introduced upload validators in order to prevent potentially dangerous files from being uploaded, see GHSA-fwcf-753v-fgcj and Content-Security-Policy definition to prevent cross-site-scripting attacks, see GHSA-2wcr-87wf-cf9j.
The upload validation checks were not robust enough which left the possibility of an attacker to circumvent them and upload a potentially dangerous file. Exploting this flaw a combination of files could be uploaded so that they work together to circumvent the existing Content-Security-Policy and allow execution of arbitrary JavaScript in the browser.
Patches
- File upload validation code has been improved
- Kiwi TCMS will now force
Content-Type: text/plain when serving uploaded files
Workarounds
- Force the Content-Type header via a custom Django middleware, see
ExtraHeadersMiddleware in https://github.com/kiwitcms/Kiwi/blob/master/tcms/core/middleware.py#L23 and/or
- Force the Content-Type header via Nginx overrides, see
location /uploads/ in https://github.com/kiwitcms/Kiwi/blob/master/etc/nginx.conf
References
Disclosed by Antonio Spataro and ek1ng. Additional credits to Ahmed Rabeaa Mosa.
References
antoniospataro Analyst
mosaa404 Analyst
ek1ng Analyst
Impact
Kiwi TCMS allows users to upload attachments to test plans, test cases, etc. Earlier versions of Kiwi TCMS had introduced upload validators in order to prevent potentially dangerous files from being uploaded, see GHSA-fwcf-753v-fgcj and Content-Security-Policy definition to prevent cross-site-scripting attacks, see GHSA-2wcr-87wf-cf9j.
The upload validation checks were not robust enough which left the possibility of an attacker to circumvent them and upload a potentially dangerous file. Exploting this flaw a combination of files could be uploaded so that they work together to circumvent the existing Content-Security-Policy and allow execution of arbitrary JavaScript in the browser.
Patches
Content-Type: text/plainwhen serving uploaded filesWorkarounds
ExtraHeadersMiddlewarein https://github.com/kiwitcms/Kiwi/blob/master/tcms/core/middleware.py#L23 and/orlocation /uploads/in https://github.com/kiwitcms/Kiwi/blob/master/etc/nginx.confReferences
Disclosed by Antonio Spataro and ek1ng. Additional credits to Ahmed Rabeaa Mosa.
References