-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch 6 #38
base: main
Are you sure you want to change the base?
Patch 6 #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Jit has detected 5 important findings in this PR that you should review.
The findings are detailed below as separate comments.
It’s highly recommended that you fix these security issues before merge.
@@ -0,0 +1,143 @@ | |||
resource "aws_s3_bucket" "data" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security control: Iac Misconfig Detection Terraform
Type: If Algorithm Is Aes256 Then The Master Key Is Null, Empty Or Undefined, Otherwise The Master Key Is Required
Description: If algorithm is AES256 then the master key is null, empty or undefined, otherwise the master key is required
Severity: HIGH
Fix suggestion:
This fix suggestion was generated by Jit. Please note that the suggestion might not always fit every use case. It is highly recommended that you check and review it before merging.
Suggestion guidelines
You can encrypt buckets by simply set the server_side_encryption attribute to AES256 in the config. The AES256 encryption method does not required mater key so it standalone in the config.
resource "aws_s3_bucket" "data" { | |
resource "aws_s3_bucket" "data" { | |
server_side_encryption_configuration { | |
rule { | |
apply_server_side_encryption_by_default { | |
sse_algorithm = "AES256" | |
} | |
} | |
} |
Jit Bot commands and options (e.g., ignore issue)
You can trigger Jit actions by commenting on this PR review:
#jit_ignore_fp
Ignore and mark this specific single instance of finding as “False Positive”#jit_ignore_accept
Ignore and mark this specific single instance of finding as “Accept Risk”#jit_undo_ignore
Undo ignore command
|
||
} | ||
|
||
resource "aws_s3_bucket" "operations" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security control: Iac Misconfig Detection Terraform
Type: If Algorithm Is Aes256 Then The Master Key Is Null, Empty Or Undefined, Otherwise The Master Key Is Required
Description: If algorithm is AES256 then the master key is null, empty or undefined, otherwise the master key is required
Severity: HIGH
Fix suggestion:
This fix suggestion was generated by Jit. Please note that the suggestion might not always fit every use case. It is highly recommended that you check and review it before merging.
Suggestion guidelines
You can encrypt buckets by simply set the server_side_encryption attribute to AES256 in the config. The AES256 encryption method does not required mater key so it standalone in the config.
resource "aws_s3_bucket" "operations" { | |
resource "aws_s3_bucket" "operations" { | |
server_side_encryption_configuration { | |
rule { | |
apply_server_side_encryption_by_default { | |
sse_algorithm = "AES256" | |
} | |
} | |
} |
Jit Bot commands and options (e.g., ignore issue)
You can trigger Jit actions by commenting on this PR review:
#jit_ignore_fp
Ignore and mark this specific single instance of finding as “False Positive”#jit_ignore_accept
Ignore and mark this specific single instance of finding as “Accept Risk”#jit_undo_ignore
Undo ignore command
}) | ||
} | ||
|
||
resource "aws_s3_bucket" "data_science" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security control: Iac Misconfig Detection Terraform
Type: If Algorithm Is Aes256 Then The Master Key Is Null, Empty Or Undefined, Otherwise The Master Key Is Required
Description: If algorithm is AES256 then the master key is null, empty or undefined, otherwise the master key is required
Severity: HIGH
Fix suggestion:
This fix suggestion was generated by Jit. Please note that the suggestion might not always fit every use case. It is highly recommended that you check and review it before merging.
Suggestion guidelines
You can encrypt buckets by simply set the server_side_encryption attribute to AES256 in the config. The AES256 encryption method does not required mater key so it standalone in the config.
resource "aws_s3_bucket" "data_science" { | |
resource "aws_s3_bucket" "data_science" { | |
server_side_encryption_configuration { | |
rule { | |
apply_server_side_encryption_by_default { | |
sse_algorithm = "AES256" | |
} | |
} | |
} |
Jit Bot commands and options (e.g., ignore issue)
You can trigger Jit actions by commenting on this PR review:
#jit_ignore_fp
Ignore and mark this specific single instance of finding as “False Positive”#jit_ignore_accept
Ignore and mark this specific single instance of finding as “Accept Risk”#jit_undo_ignore
Undo ignore command
}) | ||
} | ||
|
||
resource "aws_s3_bucket" "financials" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security control: Iac Misconfig Detection Terraform
Type: If Algorithm Is Aes256 Then The Master Key Is Null, Empty Or Undefined, Otherwise The Master Key Is Required
Description: If algorithm is AES256 then the master key is null, empty or undefined, otherwise the master key is required
Severity: HIGH
Fix suggestion:
This fix suggestion was generated by Jit. Please note that the suggestion might not always fit every use case. It is highly recommended that you check and review it before merging.
Suggestion guidelines
You can encrypt buckets by simply set the server_side_encryption attribute to AES256 in the config. The AES256 encryption method does not required mater key so it standalone in the config.
resource "aws_s3_bucket" "financials" { | |
resource "aws_s3_bucket" "financials" { | |
server_side_encryption_configuration { | |
rule { | |
apply_server_side_encryption_by_default { | |
sse_algorithm = "AES256" | |
} | |
} | |
} |
Jit Bot commands and options (e.g., ignore issue)
You can trigger Jit actions by commenting on this PR review:
#jit_ignore_fp
Ignore and mark this specific single instance of finding as “False Positive”#jit_ignore_accept
Ignore and mark this specific single instance of finding as “Accept Risk”#jit_undo_ignore
Undo ignore command
}) | ||
} | ||
|
||
resource "aws_s3_bucket_object" "data_object" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security control: Iac Misconfig Detection Terraform
Type: S3 Bucket Object Should Have Server-Side Encryption Enabled
Description: S3 Bucket Object should have server-side encryption enabled
Severity: HIGH
Fix suggestion:
This fix suggestion was generated by Jit. Please note that the suggestion might not always fit every use case. It is highly recommended that you check and review it before merging.
Suggestion guidelines
S3 Bucket Object should have server-side encryption enabled . This can be achieved by adding the enable server_side_encryption
key.
resource "aws_s3_bucket_object" "data_object" { | |
resource "aws_s3_bucket_object" "data_object" { | |
server_side_encryption = "AES256" |
Jit Bot commands and options (e.g., ignore issue)
You can trigger Jit actions by commenting on this PR review:
#jit_ignore_fp
Ignore and mark this specific single instance of finding as “False Positive”#jit_ignore_accept
Ignore and mark this specific single instance of finding as “Accept Risk”#jit_undo_ignore
Undo ignore command
No description provided.