Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Chen+24 particle spray model #386

Merged
merged 7 commits into from
Aug 22, 2024
Merged

Conversation

ybillchen
Copy link
Contributor

@ybillchen ybillchen commented Aug 6, 2024

Describe your changes

This branch implements the new Chen+24 (arXiv:2408.01496) model for stream modeling. A notebook demonstrating how to use the model is available.

-Bill Chen

Checklist

  • Did you add tests?
  • Did you add documentation for your changes?
  • Did you reference any relevant issues?
  • Did you add a changelog entry? (see CHANGES.rst)
  • Are the CI tests passing?
  • Is the milestone set?

@adrn adrn added this to the v1.9 milestone Aug 22, 2024
@adrn adrn marked this pull request as ready for review August 22, 2024 11:26
@adrn
Copy link
Owner

adrn commented Aug 22, 2024

Thanks @ybillchen -- this is looking great! I fixed some issues related to numpy 2.0, so to get the tests to pass you will need to rebase this PR. Let me know if you want help doing that!

@adrn adrn force-pushed the stream_df_chen24 branch from a7dc124 to a92dbfa Compare August 22, 2024 15:25
@adrn
Copy link
Owner

adrn commented Aug 22, 2024

I went ahead and did the rebase for you!

@adrn adrn merged commit 741677e into adrn:main Aug 22, 2024
17 checks passed
@adrn
Copy link
Owner

adrn commented Aug 22, 2024

Thanks @ybillchen!

@ybillchen
Copy link
Contributor Author

Thank you Adrian! Super happy that this is merged to gala!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants