Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thumbnails for Child Talks via ThumbnailExtractor and Downloader #498

Merged
merged 8 commits into from
Dec 7, 2024

Conversation

marcoroth
Copy link
Collaborator

@marcoroth marcoroth commented Dec 7, 2024

This pull request adds a Talk::ThumbnailExtractor and Talk::Downloader which allows a meta talk YouTube video to be downloaded so we can extract thumbnails for each of the segments for the child_talks of a Meta Talk.

The video only has to be downloaded once so the person who is committing the new talks can run the rails download_missing_meta_talks rake task to download the videos for which the thumbnails are missing and then run the rails extract_thumbnails rake task to actually extract the thumbnails.

Now the CI (seed_smoke_test) will fail if somebody forgets to extract the thumbnails, since we now run the rails verify_thumbnails rake task in CI to make sure we always have all required thumbnails.

CleanShot 2024-12-07 at 04 39 16

@marcoroth marcoroth force-pushed the thumbnail-extractor branch from e0fb5c2 to a290890 Compare December 7, 2024 04:31
@marcoroth marcoroth marked this pull request as ready for review December 7, 2024 04:34
@marcoroth marcoroth merged commit 88bc5b6 into adrienpoly:main Dec 7, 2024
4 checks passed
@marcoroth marcoroth deleted the thumbnail-extractor branch December 7, 2024 05:26
@adrienpoly
Copy link
Owner

Sweet !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants