[upstream-sync] block/buzz d8281b9c9..f956e6fe0 (1 commit) — agent development guidance refresh - #43
Merged
Merged
Conversation
## Summary - allow agents to build and run Flutter when it provides relevant implementation or validation evidence - keep mobile iteration fast by reusing simulators, incremental builds, and configured staging or production communities - correct stale CLI, E2E, CI, worktree formatting, and mobile launch guidance - point community singleton reset guidance at the canonical implementation instead of duplicating a drifting inventory ## Validation - `git diff --check origin/main..HEAD` - `cargo run -q -p buzz-cli -- --format compact messages thread --help` - `cargo run -q -p buzz-cli -- --format compact messages search --help` - `just desktop-tauri-fmt-check` from the worktree - pre-commit: mobile Dart formatting and `flutter analyze` - pre-push: branch-skew check and full mobile test suite (1,465 tests) Signed-off-by: Wes <wesbillman@users.noreply.github.com> Co-authored-by: Carl <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@buzz.block.builderlab.xyz>
Signed-off-by: adrienlacombe <6303520+adrienlacombe@users.noreply.github.com> # Conflicts: # AGENTS.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs
adrienlacombe/buzzwithblock/buzz.Range:
d8281b9c9..f956e6fe0— 1 commit.What changed upstream
Documentation only. No code, no workflows, no migrations, no dependency changes.
docs: refresh agent development guidance(docs: refresh agent development guidance block/buzz#6049) — rewrites parts of upstream'sAGENTS.mdandmobile/README.md:flutter run,flutter build,flutter clean, orflutter upgrade" rule is replaced with permission to build and run the Flutter app when it materially helps, preferringjust mobile-dev, reusing a running simulator, preserving the incremental build cache, and reporting the device/community actually exercised.just mobile-devre-described — it applies a worktree-isolated debug identity and starts/reuses the Simulator; it does not start Docker or local relay services. Same correction inmobile/README.md.resetCommunityState()as the canonical inventory.messages search --kindsgotcha inverted — the command no longer accepts--kindsand picks its own supported kinds. Raw relay filters still need explicit kinds.pnpm test:e2e:smoke/pnpm test:e2e:integration(these build the E2E bridge first) instead of a barepnpm exec playwright test.--format compactmoved before the subcommand in the Deep Links example; stale worktree-fmt gotcha dropped;just cidescription broadened.Conflicts
One, in
AGENTS.md.## Community Switching)resetCommunityState()instead.The fork's side of that hunk was not a fork patch. It was upstream's own list carrying two entries a previous sync kept in step with upstream code (
resetLinkPreviewMetadataCache,resetBackgroundMediaUploads). Both are verifiably upstream functions — they exist inupstream/mainatdesktop/src/features/communities/useCommunityInit.ts,desktop/src/shared/lib/useResolvedLinkPreviews.tsanddesktop/src/features/messages/lib/backgroundMediaUploadStore.ts— and the region carries noFORK-LOCALmarker. Nothing fork-specific was lost.Everything else auto-merged, including the two hunks that land inside fork-customized prose. Both were checked by hand afterwards:
bitcoinmarkets://paragraph survived intact, and upstream's fix to the code block applied on top. That fix is a real one for this fork: the fork's own note says--format compactis a global flag that goes before the subcommand, while the example directly beneath it still showed the trailing form. The example and the note now agree.Verification
Run on the merge commit. Every command below was executed; no result is assumed.
cargo fmt --all --checkcargo fmt --manifest-path desktop/src-tauri/Cargo.toml --all --checkcargo clippy --workspace --all-targets -- -D warningscargo clippy --manifest-path desktop/src-tauri/Cargo.toml --all-targets -- -D warningscargo metadata --lockedscripts/test-release-ref-contract.shrelease ref contract passedscripts/test-mobile-worktree-overrides.shall mobile worktree identity contract checks passedjust test-unitdart format --set-exit-if-changed .cd mobile && flutter analyzeNo issues found!cd mobile && flutter testThe mobile gates were run rather than deferred to CI: Hermit provides Dart 3.11.5 against
mobile/pubspec.yaml'ssdk: ^3.11.4, so resolution succeeds locally.Merge-history checks:
git cat-file -p HEAD \| grep -c '^parent '→ 2git rev-list --count upstream/main ^HEAD→ 0Fork-integrity checks:
AGENTS.mdtable was touched by this range — verified bygit diff --numstatacross every file in the table, includingrelease.yml,Dockerfile,tauri.conf.json,relay.rs,kind.rsandmigration.rs. All zero.migrations/;ls migrations/*.sql | cut -d_ -f1 | sort | uniq -dreports no duplicate versions.KIND_*constant changed.CLAUDE.md → AGENTS.mdsymlink intact.Needs a human look
One item, and it is a policy change rather than a merge risk.
Upstream has relaxed the mobile agent rule this fork's tooling still encodes. The daily-sync task definition at
~/.claude/scheduled-tasks/daily-upstream-sync/SKILL.mdtells the agent that "onlyflutter analyze,flutter testanddart formatare agent-safe — neverflutter run/build/clean/upgrade, perAGENTS.md." That citation is now stale:AGENTS.mdno longer says it. The task file is outside this repo, so this PR cannot fix it — deciding whether to follow upstream's relaxation or keep the stricter local rule is yours. Nothing was changed on either side pending that call.No wire-format change. No behavioural change. No fork-local patch changed meaning — this sync's entire surface is two documentation files.
Unrelated and unchanged by this PR: the entity-link scheme decision recorded in
AGENTS.mdis still open, andCodeQLonmainstill carries the pre-existingrust/hard-coded-cryptographic-valueandjs/redosfamilies noted in the triage table.