Lifecycle Effect Once API #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shpasha
reviewed
May 21, 2024
| @@ -16,6 +23,23 @@ public fun Screen.LifecycleEffect( | |||
| } | |||
| } | |||
|
|
|||
| @ExperimentalVoyagerApi | |||
| @Composable | |||
| public fun Screen.LifecycleEffectOnce(onFirstAppear: () -> Unit) { | |||
There was a problem hiding this comment.
HelloI think it would be useful to have onDisappear callback here that is called when the screen disappears from the stack
vickyleu
pushed a commit
to vickyleu/voyager
that referenced
this pull request
May 28, 2024
(cherry picked from commit ae1f915)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds to possibility to run a sync block of code, only on the first time the screen appears.
Usage:
LifecycleEffectOnce { myScreenModel.initSomething() }