fix activity leak after configuration change #415
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE SOLVED: 112
Problem
During the configuration change process, the
onDispose
method inAndroidScreenLifecycleOwner
is not called. As I understand it, this is normal, because almost allDisposableEffects
in voyager ignore configuration changes.But this leads to the fact that
atomicContext.getAndSet(null)
inonDispose
is not executed and the activity leaks.The side effect of such a leak is that when the
onDispose
method inAndroidScreenLifecycleOwner
is called, it will not work correctly, because this codeif (activity != null && activity.isChangingConfigurations) return
will complete the function execution because reference here for the old activity in which
isChangingConfigurations
is trueSolution
I simply add a callback to the lifecycle that resets the
atomicContext
field when activity is in onDestory state.