-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WASM support #289
WASM support #289
Conversation
6c3c930
to
8567a77
Compare
Does this need any testing? I would love to help in any way to get this implemented sooner. |
Everything is working pretty well so far, State restauration, etc. Just need to fix the build and migrate the Kotlin DSL to the new structure. Feel free to checkout to the branch and test by publishing locally and using in your project! |
You might have seen it already but just fyi re. 1.8.0-RC2 of Kotlinx Coroutines....I think it should mean you won't have to include atomicfu as dependency (https://github.com/Kotlin/kotlinx.coroutines/releases/tag/1.8.0-RC2) |
Thanks @joreilly , I will update the Coroutines here and see if is not required anymore. |
Hey there, I would like to test it but I don't know how to publish it locally. |
<script type="application/javascript" src="skiko.js"></script> | ||
<script type="application/javascript" src="composeApp.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we put these scripts before </body>
tag? Loading scripts inside head
tag is not recommended.
@luludevmuniz try |
When is it hoped to merge this and include in a release? |
Probably after Compose 1.6 is released |
This PR adds the support for Kotlin WASM and update the Compose to
1.6.0-rc02
.Testing WASM support:
./gradlew :samples:multiplatform:wasmJsBrowserDevelopmentRun