refactor: removing the directly dispose of ModelStore and replace with Screen Lifecycle API #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h Screen Lifecycle API
DevSrSouza
commented
Oct 19, 2023
Comment on lines
+37
to
39
| val screenModelStore = remember(this) { | ||
| ScreenLifecycleStore.register(this) { ScreenModelStore } | ||
| } |
There was a problem hiding this comment.
This garantes that the ScreenLifecycleStore is being registered for this screen
Syer10
approved these changes
Oct 19, 2023
adrielcafe
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proposal to remove all extensions APIs (in this case ScreenModel API) from the
disposefunction of the Navigator, there is no need for it currently, it can be replaced withScreenLifecycleStore.This will decouple the Navigator of the Screen Model API.